Skip to content

Conversation

@JoelSpeed
Copy link
Contributor

In combination with openshift/machine-config-operator#3688, this was causing an issue in TechPreview clusters.

Myself and @sergiordlr both observed that, when enabled in the cluster by the machine-config-operator, this feature gate got passed through to the Kubelet and weird interactions were happening between kubelet and crio causing odd behaviour and duplicate containers/bind address issues.

In my testing, disabling this feature lead to a healthy cluster within 3688. In these test runs the tech preview clusters bootstrapped correctly where previously they had been failing to bootstrap, this run was against a commit that deliberately excluded passing EventedPLEG to the kubelet.

Discussion in slack here and here

If we exclude the feature for now, once 3688 has merged, we can reintroduce this and test via a PR to cluster-config-operator to make sure track any issues being caused. Currently, because MCO was not up to date, it had not been able to be tested in the cluster pre-merge.

CC @harche @sairameshv

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2023
@openshift-ci openshift-ci bot requested review from bparees and soltysh June 5, 2023 09:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sairameshv
Copy link
Member

/lgtm
Once the MCO PR gets merged, this needs to be re-enabled !!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sairameshv
Copy link
Member

The issue while enabling the EventedPLEG featuregate in Kubelet has been identified and fixed upstream here

@JoelSpeed JoelSpeed deleted the evented-pleg-off branch January 28, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants